Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AND-159] Ensure ChatClient is initialized before internal SDK activities are started #5510

Merged
merged 2 commits into from
Dec 11, 2024
Merged

[AND-159] Ensure ChatClient is initialized before internal SDK activities are started #5510

merged 2 commits into from
Dec 11, 2024

Conversation

JcMinarro
Copy link
Member

🎯 Goal

Ensure ChatClient is initialized before internal SDK activities are started

🎉 GIF

@JcMinarro JcMinarro requested a review from a team as a code owner December 9, 2024 11:52
VelikovPetar
VelikovPetar reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@VelikovPetar VelikovPetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is another activity that should be covered with such check: AttachmentDocumentActivity from the stream-chat-android-ui-common module.

@JcMinarro JcMinarro enabled auto-merge (squash) December 11, 2024 12:48
@JcMinarro JcMinarro merged commit 47f7df2 into develop Dec 11, 2024
9 checks passed
@JcMinarro JcMinarro deleted the fix/sdk-activities branch December 11, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VelikovPetar VelikovPetar VelikovPetar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JcMinarro @VelikovPetar