Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Implement SonarCloud #5511

Merged
merged 10 commits into from
Jan 7, 2025
Merged

[CI] Implement SonarCloud #5511

merged 10 commits into from
Jan 7, 2025

Conversation

testableapple
Copy link
Collaborator

@testableapple testableapple commented Dec 9, 2024

Resolve https://linear.app/stream/issue/AND-59

🎯 Goal

🛠 Implementation details

  • Use Jacoco to get test coverage
  • Use SonarQube gradle plugin to upload test coverage to SonarCloud
  • Update UnitTestsFilter.kt to include new commands

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

gif

@testableapple testableapple force-pushed the ci/sonar-cloud branch 4 times, most recently from 85dbeae to 813e204 Compare December 11, 2024 16:18
@GetStream GetStream deleted a comment from sonarqubecloud bot Dec 11, 2024
@GetStream GetStream deleted a comment from sonarqubecloud bot Dec 11, 2024
@GetStream GetStream deleted a comment from sonarqubecloud bot Dec 11, 2024
@GetStream GetStream deleted a comment from sonarqubecloud bot Dec 11, 2024
@GetStream GetStream deleted a comment from sonarqubecloud bot Dec 11, 2024
@testableapple testableapple marked this pull request as ready for review December 11, 2024 18:10
@testableapple testableapple requested a review from a team as a code owner December 11, 2024 18:10
coverage.gradle Outdated Show resolved Hide resolved
.github/workflows/snapshot-test.yaml Show resolved Hide resolved
sonar.gradle Outdated Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
Copy link
Member

@JcMinarro JcMinarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not merge it until #5534 is merged

@JcMinarro JcMinarro force-pushed the ci/sonar-cloud branch 2 times, most recently from 4f0b065 to 9396063 Compare January 2, 2025 11:20
Copy link
Contributor

github-actions bot commented Jan 6, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.04 MB 3.04 MB 0.00 MB 🟢
stream-chat-android-offline 3.25 MB 3.25 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.91 MB 7.91 MB 0.00 MB 🟢
stream-chat-android-compose 9.03 MB 9.03 MB 0.00 MB 🟢

@testableapple testableapple enabled auto-merge (squash) January 7, 2025 11:13
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
11.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@testableapple testableapple merged commit 1a67f8e into develop Jan 7, 2025
11 of 12 checks passed
@testableapple testableapple deleted the ci/sonar-cloud branch January 7, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants