-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AND-199] Implement ComposerActionsTheme for customizing the message composer action icons. #5535
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
* @param commandsButton The style for the commands button. | ||
* @param sendButton The style for the send button. | ||
*/ | ||
public data class ComposerActionsTheme( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can attach @Immuable
annotation here to make sure the properties of this theme style wouldn't be changed after the initial creation.
SDK Size Comparison 📏
|
# Conflicts: # stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/composer/MessageComposer.kt
CHANGELOG.md
Outdated
@@ -12,7 +12,7 @@ | |||
|
|||
## stream-chat-android-client | |||
### 🐞 Fixed | |||
- Fix `ChatClient::queryBlockedMembers` not working. [#5532](https://github.com/GetStream/stream-chat-android/pull/5532) | |||
- Fix `ChatClient::queryBlockedUsers` not working. [#5532](https://github.com/GetStream/stream-chat-android/pull/5532) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this unrelated change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realised that I previously made a typo in the changelog (the correct name is queryBlockedUsers
), so I updated it here. I can revert this change and fix it separately, so that it is not confusing why is it in this commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed here: c229890 (I will fix the changeling in a separate PR)
🎯 Goal
Linear: https://linear.app/stream/issue/AND-199/implement-icon-customisation-options-for-messagecomposer-in-compose
Exposes a way to customise the default message composer icons (attachments / commands / send) without overriding each component separately.
🛠 Implementation details
ComposerActionsTheme
which holds anIconContainerStyle
for each default action in the composer (attachments / commands / send)actionsTheme : ComposerActionsTheme
via theMessageComposerTheme
ChatTheme.messageComposerTheme.actionsTheme
Example (overriding the default attachments button):
Will produce the following message composer (sample app):
🧪 Testing
Provide the patch summary here