refactor: make use of SSOT for attachment picker tab logic #5614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also allows for a custom initial tab
tafelnl
force-pushed
the
refactor/attachment-picker-tab-ssot
branch
from
fcd9555 to
011fe7e
Compare
|
This pull request has been automatically marked as stale because it has been inactive for 14 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request was closed because it has been stalled for 7 days with no activity. Please reopen if you still intend to submit this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
selectedTabIndexandselectedAttachmentsPickerModecan be (and eventually will be) out of sync withattachmentsPickerViewModel.attachmentPickerMode. This PR introduces a SSOT strategy. With this new strategy it also allows for a custom initial tab