Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add Attachments and Link previews related E2E tests #5622

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

testableapple
Copy link
Contributor

Resolve https://linear.app/stream/issue/AND-186
Resolve https://linear.app/stream/issue/AND-222

🎯 Goal

Copy-paste all the Attachments and Link previews related E2E tests from iOS to Android

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

gif

@testableapple testableapple force-pushed the ci/add-attachments-e2e-tests branch from 34660d1 to 588460f Compare February 6, 2025 16:50
Copy link
Contributor

github-actions bot commented Feb 6, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.17 MB 3.17 MB 0.00 MB 🟢
stream-chat-android-offline 3.38 MB 3.38 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.86 MB 7.86 MB 0.00 MB 🟢
stream-chat-android-compose 8.75 MB 8.75 MB 0.00 MB 🟢

@testableapple testableapple force-pushed the ci/add-attachments-e2e-tests branch 3 times, most recently from 72b6a66 to 7967ceb Compare February 7, 2025 10:46
@testableapple testableapple force-pushed the ci/add-attachments-e2e-tests branch from 7967ceb to 44b07af Compare February 7, 2025 10:47
@testableapple testableapple marked this pull request as ready for review February 7, 2025 10:47
@testableapple testableapple requested a review from a team as a code owner February 7, 2025 10:47
@testableapple testableapple enabled auto-merge (squash) February 7, 2025 11:04
Copy link
Contributor

@VelikovPetar VelikovPetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@testableapple testableapple merged commit adff5fe into develop Feb 13, 2025
12 of 13 checks passed
@testableapple testableapple deleted the ci/add-attachments-e2e-tests branch February 13, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants