Fix ImagePicker crash and optimize changeSelectedAttachments. (#5804) #5805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sagar0-0
commented
Jun 3, 2025
| val dataSet = attachments | ||
|
|
||
| val itemIndex = dataSet.indexOf(attachmentItem) | ||
| val itemIndex = dataSet.indexOfFirst { it.attachmentMetaData == attachmentItem.attachmentMetaData } |
There was a problem hiding this comment.
Sometimes isSelected might not be updated into the dataset so the index can be -1 if we use indexOf(). This kotlin function will never give us index -1.
Sagar0-0
commented
Jun 3, 2025
|
|
||
| newFiles.removeAt(itemIndex) | ||
| newFiles.add(itemIndex, newItem) | ||
| newFiles[itemIndex] = newItem |
There was a problem hiding this comment.
Optimize the O(n) + O(n) remove and add to O(1).
|
This pull request has been automatically marked as stale because it has been inactive for 14 days. It will be closed in 7 days if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Closes #5804
🛠 Implementation details
Although they have fixed it in 1.8+, we can use this approach for the time being. I don't think there are any cons of using
onImageSelectedin a coroutine.🧪 Testing
Manually test by attaching a Layout Inspector on a slow device. Select and deselect as fast as you can. It won't crash.
☑️Contributor Checklist
General
Code & documentation
☑️Reviewer Checklist