feat: Add type field support on create_blocklist() #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
viktorapo808
force-pushed
the
add-type-support-on-create-blocklist
branch
from
90ad390 to
1167cd8
Compare
gumuz
reviewed
Nov 20, 2023
gumuz
approved these changes
Nov 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request
For the regex blocklists we need to introduce a new
typefield in the DB to be able to distinguish between regular and regex blocklist (type). Therefore, when creating blocklist through the dashboard/SDK we need to pass thetypefield in the payload. In future, ideally this should support more types.With the current change I extended the
create_blocklist()method with an optional parameter that should pass thetypefield to the request payload