Skip to content

feat: Add support for mark_unread msg or thread #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2024
Merged

feat: Add support for mark_unread msg or thread #172

merged 1 commit into from
Jul 3, 2024

Conversation

guerinoni
Copy link
Contributor

@guerinoni guerinoni commented Jul 3, 2024 •
edited
Loading

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Add new api mark_unread for marking thread or message (thread_id // message_id)

@guerinoni guerinoni requested a review from gumuz as a code owner July 3, 2024 12:49
gumuz
gumuz suggested changes Jul 3, 2024
View reviewed changes
gumuz
gumuz reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@gumuz gumuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know enough about these endpoints to test their correctness, but tests are failing

@guerinoni guerinoni force-pushed the PBE-4273 branch 2 times, most recently from f7db770 to 533c3ca Compare July 3, 2024 14:15
@guerinoni guerinoni requested a review from gumuz July 3, 2024 14:47
gumuz
gumuz approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@gumuz gumuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guerinoni guerinoni merged commit 1981ab7 into master Jul 3, 2024
6 checks passed
@guerinoni guerinoni deleted the PBE-4273 branch July 3, 2024 15:42
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@gumuz gumuz gumuz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guerinoni @gumuz