fix: channel.visible not taking sort and pinned channels into account

[isekovanic]

🎯 Goal

This PR fixes an issue with channel pinning where pinned channels aren't respected if a channel goes from hidden to visible.

Steps to reproduce:

• Pin 1 or more channels within ChannelList
• Take another channel (not a pinned one) and channel.hide() it
• After that, run channel.show() without reloading the app (so that no HTTP requests are done in the meantime)
• The recently shown channel will not respect pinned ones

Also, pretty sure that notification.message_new handler is also incorrect since it doesn't take archiving into account, but will look into that on Monday.

Update: This was indeed an issue with notification.message_new as well and is fixed in this PR.

This is already fixed in the recent reactive channel list state PR in the LLC, but porting it here too so that we don't leave the SDK with a bug until that one gets merged.

🛠 Implementation details

🎨 UI Changes

iOS

Before	After

Android

Before	After

🧪 Testing

☑️ Checklist

• I have signed the Stream CLA (required)
• PR targets the develop branch
• Documentation is updated
• New code is tested in main example apps, including all possible scenarios
  • SampleApp iOS and Android
  • Expo iOS and Android

[Stream-SDK-Bot]

SDK Size

title	develop	branch	diff	status
js_bundle_size	468 KB	468 KB	0 B	🟢

[khushal87]

Also, pretty sure that notification.message_new handler is also incorrect since it doesn't take archiving into account, but will look into that on Monday.

I am not sure if I understand this correctly. We added a condition for handling archiving channels in the notification.message_new handler though. Let me know if I am missing something.

[isekovanic]

Also, pretty sure that notification.message_new handler is also incorrect since it doesn't take archiving into account, but will look into that on Monday.

I am not sure if I understand this correctly. We added a condition for handling archiving channels in the notification.message_new handler though. Let me know if I am missing something.

That's my bad, I meant to say that pinning isn't respected *

[stream-ci-bot]

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀