Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust release process #2125

Merged
merged 5 commits into from
Oct 13, 2023
Merged

chore: adjust release process #2125

merged 5 commits into from
Oct 13, 2023

Conversation

arnautov-anton
Copy link
Contributor

@arnautov-anton arnautov-anton commented Oct 12, 2023

🎯 Goal

  • make documentation publishing part of the release process, add option to publish documentation without triggering the release of the package
  • release docs from ANY branch (no limitation)
  • release to either of the two options (prod or staging)
  • add PR title check (like we have in stream-video-js)

I have already changed the release process to workflow_dispatch - this is just the extension of that commit that takes the documentation into consideration.

Obviously this commit should be followed by the removal of the develop branch which is no longer needed. By doing that we won't be confusing semantic-release which relies on merged commits do do the comparisons:

# [11.0.0-rc.1](https://github.com/GetStream/stream-chat-react/compare/v10.13.1...v11.0.0-rc.1) (2023-10-12)
### Bug Fixes
* **emoji-mart:** new reactions ([#1947](https://github.com/GetStream/stream-chat-react/issues/1947)) ([2050708](https://github.com/GetStream/stream-chat-react/commit/205070822d00b033cf5be0c2e3e6063d5cd90503))
### Features
* allow complete channel list throttled reload on internet connection recovery ([#2123](https://github.com/GetStream/stream-chat-react/issues/2123)) ([252cac3](https://github.com/GetStream/stream-chat-react/commit/252cac3366986523b9f6b1152c9408ccab0af710))
### BREAKING CHANGES
* **emoji-mart:** `reactionOptions` signature has changed, see [release guide](https://github.com/GetStream/stream-chat-react/blob/7a19e386aa3adcc5741a7f0d92bc816a1a424094/docusaurus/docs/React/release-guides/new-reactions.mdx) for more information

Releasing on rc withouth prior merge of master -> develop -> rc caused an issue where a feature that has been already released has been added to the CHANGELOG.md as new feature. This process adjustment should reduce the unnecessary overhead.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bd32b26) 83.24% compared to head (11f8dac) 83.24%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2125   +/-   ##
========================================
  Coverage    83.24%   83.24%           
========================================
  Files          293      293           
  Lines         7032     7032           
  Branches      2003     2003           
========================================
  Hits          5854     5854           
  Misses         848      848           
  Partials       330      330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

runs-on: ubuntu-latest
# GH does not allow to limit branches in the workflow_dispatch settings so this here is a safety measure
if: ${{ github.ref_name == 'master' || github.ref_name == 'rc' || github.ref_name == 'release-v9' }}
if: ${{ inputs.docs_only == 'false' || github.ref_name == 'master' || github.ref_name == 'rc' || github.ref_name == 'release-v9' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will probably need some regex here in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either that or we could use some sort of "element in array" thingy, did not pursue this any further though as this will suffice for the time being.

developers/RELEASE.md Outdated Show resolved Hide resolved
developers/RELEASE.md Outdated Show resolved Hide resolved
MartinCupela
MartinCupela previously approved these changes Oct 13, 2023
@arnautov-anton arnautov-anton merged commit f7411aa into develop Oct 13, 2023
4 of 5 checks passed
@arnautov-anton arnautov-anton deleted the chore/release-process branch October 13, 2023 13:18
@github-actions
Copy link

🎉 This PR is included in version 10.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stream-ci-bot
Copy link
Collaborator

🎉 This PR is included in version 11.0.0-rc.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants