-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adjust release process #2125
Conversation
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #2125 +/- ##
========================================
Coverage 83.24% 83.24%
========================================
Files 293 293
Lines 7032 7032
Branches 2003 2003
========================================
Hits 5854 5854
Misses 848 848
Partials 330 330 ☔ View full report in Codecov by Sentry. |
runs-on: ubuntu-latest | ||
# GH does not allow to limit branches in the workflow_dispatch settings so this here is a safety measure | ||
if: ${{ github.ref_name == 'master' || github.ref_name == 'rc' || github.ref_name == 'release-v9' }} | ||
if: ${{ inputs.docs_only == 'false' || github.ref_name == 'master' || github.ref_name == 'rc' || github.ref_name == 'release-v9' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will probably need some regex here in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either that or we could use some sort of "element in array" thingy, did not pursue this any further though as this will suffice for the time being.
Co-authored-by: MartinCupela <[email protected]>
6520f20
to
7c871d8
Compare
🎉 This PR is included in version 10.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 11.0.0-rc.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎯 Goal
stream-video-js
)I have already changed the release process to
workflow_dispatch
- this is just the extension of that commit that takes the documentation into consideration.Obviously this commit should be followed by the removal of the
develop
branch which is no longer needed. By doing that we won't be confusingsemantic-release
which relies on merged commits do do the comparisons:stream-chat-react/CHANGELOG.md
Lines 1 to 16 in 2145665
Releasing on
rc
withouth prior merge ofmaster
->develop
->rc
caused an issue where a feature that has been already released has been added to theCHANGELOG.md
as new feature. This process adjustment should reduce the unnecessary overhead.