feat(VirtualizedMessageList): allow to merge custom virtuoso components with the SDK defaults #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts with the SDK defaults
…irtuoso-components-with-defaults
|
Size Change: +2.67 kB (0%) Total Size: 1.9 MB
ℹ️ View Unchanged
|
oliverlaz
reviewed
Oct 23, 2023
src/components/MessageList/hooks/VirtualizedMessageList/useVirtualizedMessageListComponents.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2140 +/- ##
==========================================
+ Coverage 83.24% 83.62% +0.38%
==========================================
Files 293 300 +7
Lines 7032 7067 +35
Branches 1892 1895 +3
==========================================
+ Hits 5854 5910 +56
+ Misses 1019 995 -24
- Partials 159 162 +3
☔ View full report in Codecov by Sentry. |
…e-custom-virtuoso-components-with-defaults' into feat/VirtualizedMessagelist/merge-custom-virtuoso-components-with-defaults
oliverlaz
approved these changes
Oct 25, 2023
…irtuoso-components-with-defaults
MartinCupela
deleted the
feat/VirtualizedMessagelist/merge-custom-virtuoso-components-with-defaults
branch
|
🎉 This PR is included in version 10.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
github-actions bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
# [11.0.0-rc.2](v11.0.0-rc.1...v11.0.0-rc.2) (2023-10-27) ### Bug Fixes * **emoji-mart:** simplify EmojiPicker & EmojiIndex integration ([#2117](#2117)) ([60c24b8](60c24b8)) ### Features * **renderText:** allow custom remark and rehype plugin composition ([#2142](#2142)) ([4a25912](4a25912)) * **VirtualizedMessageList:** allow to merge custom virtuoso components with the SDK defaults ([#2140](#2140)) ([6ea9ff0](6ea9ff0)) ### BREAKING CHANGES * **emoji-mart:** `EmojiPicker` and `EmojiIndex` have changed, see release guides in #2117 for more information
|
🎉 This PR is included in version 11.0.0-rc.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow integrators to add only some custom virtuoso components via
VirtualizedMessageListProps['additionalVirtuosoProps']['components']and the rest to be filled with the defaults provided by the SDK.🛠 Implementation details
The
MessageList/hooksdirectory structure has changed. Now the hooks used exclusively byVirtualizedMessageListare placed inhooks/VirtualizedMessageListand those used exclusively byMessageListare stored inhooks/MessageList. All the hooks that used to be exported from theMessageList/hooksfolder are still exported.I have also extracted new hooks from
VirtualizedMessageListcode and placed them intohooks/VirtualizedMessageList. These are not exported for the integrators to use. These hooks are:useMessageSetKeyuseScrollToBottomOnNewMessage🎨 UI Changes
None.