feat: expose channels state on chat level #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +452 B (0%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Nov 7, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2161 +/- ##
==========================================
+ Coverage 83.65% 83.68% +0.02%
==========================================
Files 307 307
Lines 7111 7115 +4
Branches 2017 2017
==========================================
+ Hits 5949 5954 +5
+ Misses 829 828 -1
Partials 333 333
☔ View full report in Codecov by Sentry. |
Co-authored-by: Anton Arnautov <[email protected]>
…at-level' into feat/expose-channels-state-on-chat-level
arnautov-anton
approved these changes
Nov 7, 2023
oliverlaz
approved these changes
Nov 7, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
## [10.18.0](v10.17.0...v10.18.0) (2023-11-07) ### Features * expose channels state on chat level ([#2161](#2161)) ([7e5543b](7e5543b))
|
🎉 This PR is included in version 10.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
## [11.0.0-rc.4](v11.0.0-rc.3...v11.0.0-rc.4) (2023-11-08) ### Bug Fixes * **i18n:** add missing SDK translations ([#2157](#2157)) ([e22a6ce](e22a6ce)) * **i18n:** do not translate command names ([#2155](#2155)) ([b654b9a](b654b9a)) * **i18n:** prevent removal of dynamically generated translation keys ([#2154](#2154)) ([ebcaa8f](ebcaa8f)) * List/Item & EmojiPicker async data loading + docs update ([dedefac](dedefac)) ### Features * add Channel prop doDeleteMessageRequest ([#2152](#2152)) ([a01774a](a01774a)) * expose channels state on chat level ([#2161](#2161)) ([7e5543b](7e5543b))
|
🎉 This PR is included in version 11.0.0-rc.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
MartinCupela
added a commit
that referenced
this pull request
Nov 23, 2023
This reverts commit 7e5543b.
MartinCupela
added a commit
that referenced
this pull request
Nov 30, 2023
MartinCupela
added a commit
that referenced
this pull request
Dec 1, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
## [11.1.0](v11.0.0...v11.1.0) (2023-12-01) ### Bug Fixes * revert "feat: expose channels state on chat level ([#2161](#2161))" ([#2184](#2184)) ([32e4867](32e4867)) ### Features * add BaseImage component with image fallback display ([#2183](#2183)) ([ec1d79b](ec1d79b)) * add channel list context ([#2187](#2187)) ([fd5ea67](fd5ea67)) * render BaseImage image fallback within the same img element ([#2200](#2200)) ([2fcd564](2fcd564)) ### Chores * **deps:** bump @stream-io/stream-chat-css from 4.0.0 to 4.1.0 ([e600e3c](e600e3c)) * **deps:** bump stream-chat from 8.14.3 to 8.14.4 ([#2199](#2199)) ([a4dd57f](a4dd57f)) * **deps:** move `@stream-io/stream-chat-css` to `devDeps` ([#2191](#2191)) ([61af19c](61af19c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow the integrators to control the
channelsstate outside theChannelListcomponent. Keeping the state insideChannelListforces the SDK maintainers to provide props through which the integrators could somehow impact the channels state, but still not allowing for full control. An example would be that of blocking the integrators from controlling how custom active channel is queried as the default implementation does not allow to customize the query filters etc.It is unrealistic to keep adding new props, that would hook into different parts of the
ChannelListcode base. Therefore thechannelsstate controller is exposed to all the components rendered within theChatContext.This PR does not introduce breaking changes and therefore the
usePaginatedChannelshook keeps forwarding thechannelsandsetChannelsvalues. This should be refactored in the future.