Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add centralized dialog management #2489

Merged
merged 33 commits into from
Sep 16, 2024

refactor: remove openDialogCount from DialogManager

4f120a4
Select commit
Loading
Failed to load commit list.
Merged

feat: add centralized dialog management #2489

refactor: remove openDialogCount from DialogManager
4f120a4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 11, 2024 in 0s

86.53% (target 70.00%)

View this Pull Request on Codecov

86.53% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 94.94585% with 14 lines in your changes missing coverage. Please review.

Project coverage is 86.53%. Comparing base (941707d) to head (4f120a4).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Dialog/DialogManager.ts 92.50% 3 Missing ⚠️
.../components/MessageList/VirtualizedMessageList.tsx 40.00% 0 Missing and 3 partials ⚠️
src/components/Reactions/ReactionSelector.tsx 95.31% 2 Missing and 1 partial ⚠️
src/components/Dialog/DialogAnchor.tsx 93.93% 2 Missing ⚠️
src/components/MessageList/MessageList.tsx 60.00% 0 Missing and 2 partials ⚠️
src/components/Message/utils.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2489      +/-   ##
==========================================
+ Coverage   84.50%   86.53%   +2.02%     
==========================================
  Files         384      392       +8     
  Lines        8105     8189      +84     
  Branches     1955     1962       +7     
==========================================
+ Hits         6849     7086     +237     
+ Misses       1165     1015     -150     
+ Partials       91       88       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov