-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: prevent filtering a message which is being reacted to #2514
Draft
arnautov-anton
wants to merge
1
commit into
master
Choose a base branch
from
perf/timestamp-changed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +62 B (+0.01%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
arnautov-anton
force-pushed
the
perf/timestamp-changed
branch
from
September 20, 2024 22:07
24a9ea1
to
65dcf33
Compare
arnautov-anton
force-pushed
the
perf/timestamp-changed
branch
from
October 5, 2024 08:03
65dcf33
to
aea4ede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The
updateMessage
function has been missingtimestampChanged
parameter, which if set tofalse
prevents underlyingaddToMessageList
function from filtering the message that is being altered in a way, wherecreated_at
has not been changed.