fix: give preference to pasting text over files #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -23 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2552 +/- ##
=======================================
Coverage 83.18% 83.18%
=======================================
Files 437 437
Lines 9113 9113
Branches 2232 2232
=======================================
Hits 7581 7581
Misses 1204 1204
Partials 328 328 ☔ View full report in Codecov by Sentry. |
oliverlaz
approved these changes
Nov 6, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
## [12.5.1](v12.5.0...v12.5.1) (2024-11-06) ### Bug Fixes * give preference to pasting text over files ([#2552](#2552)) ([652ae33](652ae33))
|
🎉 This PR is included in version 12.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
When a website content is copied or MS Word content is copied, the clipboards DataTransferItemList contains two items:
The type
text/htmlcarries information about images, that can be uploaded to the back-end. Until now, if both item types were present, thetext/plaintype was ignored and images were extracted and uploaded from thetext/htmltype. This lead to surprising behavior of user instead of observing the copied text to be pasted into the message composer, the images to be added as attachments.This PR changes this behavior by giving preference to pasting text over images as chat applications usually do. The
text/htmlcontent us thus ignored.