chore: [REACT-716] example application deployment and release adjustments #2900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2900 +/- ##
=======================================
Coverage 81.03% 81.03%
=======================================
Files 506 506
Lines 10555 10555
Branches 2414 2414
=======================================
Hits 8553 8553
Misses 1872 1872
Partials 130 130 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arnautov-anton
force-pushed
the
chore/vercel-deployment-and-release-adjustments
branch
6 times, most recently
from
4f66516 to
af7f792
Compare
arnautov-anton
force-pushed
the
chore/vercel-deployment-and-release-adjustments
branch
from
af7f792 to
5d4bd81
Compare
arnautov-anton
requested review from
MartinCupela and
oliverlaz
as code owners
arnautov-anton
changed the title
|
|
||
| const tokenProvider = useCallback(() => { | ||
| return fetch( | ||
| `https://pronto.getstream.io/api/auth/create-token?environment=shared-chat-redesign&user_id=${userId}`, |
Contributor
There was a problem hiding this comment.
Is it ok to have this publicly hard-coded?
Contributor
Author
There was a problem hiding this comment.
Yup, Zita does the same for her feeds tutorial. The secret is not visible, the app behind it is for testing purposes only, tokens are short lived and can be revoked if necessary - the secret can be rotated too preventing Pronto from generating new ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Create a Vercel CI deployment setup and adjust
.releasercto makemasterinto acanaryrelease channel.