V5: Fix build warnings #3904
Open
V5: Fix build warnings #3904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
laevandus
commented
Dec 19, 2025
Comment on lines
-61
to
+67
| var results: [NSManagedObject]? | ||
| nonisolated(unsafe) var modelMapping: [DatabaseId: NSManagedObjectID] = [:] | ||
| context.performAndWait { | ||
| results = modelClass.batchFetch(keyPath: keyPath, equalTo: values, context: context) | ||
| } | ||
| guard let results = results else { continue } | ||
|
|
||
| var modelMapping: [DatabaseId: NSManagedObjectID] = [:] | ||
| results.forEach { | ||
| if let id = modelClass.id(for: $0) { | ||
| modelMapping[id] = $0.objectID | ||
| let results = modelClass.batchFetch(keyPath: keyPath, equalTo: values, context: context) | ||
| results.forEach { | ||
| if let id = modelClass.id(for: $0) { | ||
| modelMapping[id] = $0.objectID | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This was interesting because DTOs were leaking outside of context's queue
Member
There was a problem hiding this comment.
Interesting... Could this be causing this crash: #3905?
Member
There was a problem hiding this comment.
We might need to fix this on v4 as well
laevandus
commented
Dec 19, 2025
| public let extraData: [String: RawJSON] | ||
| } | ||
|
|
||
| extension ChatThread: Hashable { |
laevandus
commented
Dec 19, 2025
| context: self.database.backgroundReadOnlyContext, | ||
| fetchRequest: MessageDTO | ||
| .messagesPendingSendFetchRequest() | ||
| private lazy var observer = StateLayerDatabaseObserver<ListResult, MessageSendingQueue.SendRequest, MessageDTO>( |
Contributor
Author
There was a problem hiding this comment.
Makes sense to convert earlier, also makes sure DTOs don't escape from context's thread
Generated by 🚫 Danger |
nuno-vieira
reviewed
Dec 19, 2025
Comment on lines
-118
to
-140
| /// Returns max possible attachment size in bytes. | ||
| /// By default the value is taken from `CDNClient.maxAttachmentSize` type. | ||
| /// But it can be overridden by setting a value here. | ||
| @available(*, deprecated, message: "The max attachment size can now be set from the Stream's Dashboard App Settings. It supports setting a size limit per attachment type.") | ||
| public var maxAttachmentSize: Int64 { | ||
| // TODO: For v5 the maxAttachmentSize should be responsibility of the UI SDK. | ||
| // Since this is not even used in the StreamChat LLC SDK. | ||
| get { | ||
| if let overrideMaxAttachmentSize = self.overrideMaxAttachmentSize { | ||
| return overrideMaxAttachmentSize | ||
| } else if let customCDNClient = customCDNClient { | ||
| return type(of: customCDNClient).maxAttachmentSize | ||
| } else { | ||
| return StreamCDNClient.maxAttachmentSize | ||
| } | ||
| } | ||
| set { | ||
| overrideMaxAttachmentSize = newValue | ||
| } | ||
| } | ||
|
|
||
| /// Used to override the maxAttachmentSize, by setting the value in the config instead of relying on `CDNClient`. | ||
| private var overrideMaxAttachmentSize: Int64? |
Collaborator
SDK Size
|
Collaborator
SDK Performance
|
Collaborator
StreamChat XCSize
Show 391 more objects
|
Collaborator
StreamChatUI XCSize
Show 296 more objects
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Fixes: IOS-1193
🎯 Goal
Fix build warnings in StreamChat and StreamChatUI since it is not great to have them for customers
📝 Summary
🛠 Implementation
☑️ Contributor Checklist
docs-contentrepo