Skip to content

Commit

Permalink
dogfooding fixes (#668)
Browse files Browse the repository at this point in the history
Co-authored-by: Deven Joshi <[email protected]>
  • Loading branch information
Brazol and deven98 authored May 8, 2024
1 parent 950d413 commit ab13bea
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 8 deletions.
4 changes: 2 additions & 2 deletions dogfooding/lib/app/app_content.dart
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class _StreamDogFoodingAppContentState

final extra = (
call: result.data,
connectOptions: const CallConnectOptions(),
connectOptions: null,
);

_router.push(CallRoute($extra: extra).location, extra: extra);
Expand Down Expand Up @@ -237,7 +237,7 @@ class _StreamDogFoodingAppContentState
// Navigate to the call screen.
final extra = (
call: callToJoin,
connectOptions: const CallConnectOptions(),
connectOptions: null,
);
_router.push(CallRoute($extra: extra).location, extra: extra);
}
Expand Down
2 changes: 1 addition & 1 deletion dogfooding/lib/router/routes.dart
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class CallRoute extends GoRouteData {

final ({
Call call,
CallConnectOptions connectOptions,
CallConnectOptions? connectOptions,
}) $extra;

@override
Expand Down
3 changes: 2 additions & 1 deletion dogfooding/lib/router/routes.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions dogfooding/lib/screens/call_screen.dart
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ class CallScreen extends StatefulWidget {
const CallScreen({
super.key,
required this.call,
this.connectOptions = const CallConnectOptions(),
this.connectOptions,
});

final Call call;
final CallConnectOptions connectOptions;
final CallConnectOptions? connectOptions;

@override
State<CallScreen> createState() => _CallScreenState();
Expand Down
2 changes: 1 addition & 1 deletion dogfooding/lib/screens/home_screen.dart
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class _HomeScreenState extends State<HomeScreen> {
if (isRinging) {
CallRoute($extra: (
call: _call!,
connectOptions: const CallConnectOptions(),
connectOptions: null,
)).push(context);
} else {
LobbyRoute($extra: _call!).push(context);
Expand Down
2 changes: 1 addition & 1 deletion dogfooding/lib/screens/login_screen.dart
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class _LoginScreenState extends State<LoginScreen> {

final userInfo = UserInfo(
role: 'admin',
id: email,
id: email.replaceAll('@', '_').replaceAll('.', '_'),
name: email,
);

Expand Down

0 comments on commit ab13bea

Please sign in to comment.