Skip to content

feat: Closed captions#796

Merged
Brazol merged 61 commits intomainfrom
feat/closed-captions
Jan 15, 2025
Merged

feat: Closed captions#796
Brazol merged 61 commits intomainfrom
feat/closed-captions

Conversation

@Brazol
Copy link
Copy Markdown
Contributor

@Brazol Brazol commented Nov 18, 2024

This PR adds support for Closed Captions feature to our Flutter Video SDK.

Key Changes

  • Closed Captions Support:

    • Added the Call.closedCaptions stream to enable overlaying captions during calls.
    • Introduced new configuration options in CallPreferences:
      • closedCaptionsRetentionTimeInMs: Controls the duration captions are displayed.
      • closedCaptionsQueueSize: Manages the number of captions in the display queue.
  • Regenerated OpenAPI Models:

    • Updated models required for the Closed Captions implementation.
  • Dogfooding App Enhancements:

    • Updated the app with options to toggle and display closed captions, enabling testing and demonstration of the new feature.

Docs: https://github.com/GetStream/docs-content/pull/19

@Brazol Brazol requested a review from a team as a code owner November 18, 2024 09:18
@Brazol Brazol changed the title Closed captions feat: Closed captions Nov 18, 2024
Brazol and others added 14 commits December 30, 2024 11:03
# Conflicts:
#	packages/stream_video_push_notification/pubspec.yaml
# Conflicts:
#	.github/workflows/app-distribute.yml
#	packages/stream_video/lib/src/call/session/call_session.dart
#	packages/stream_video/lib/src/webrtc/rtc_manager.dart
#	packages/stream_video/pubspec.yaml
#	packages/stream_video_flutter/example/pubspec.yaml
#	packages/stream_video_flutter/lib/src/video_effects/video_effects_manager.dart
#	packages/stream_video_flutter/pubspec.yaml
#	packages/stream_video_push_notification/pubspec.yaml
# Conflicts:
#	dogfooding/lib/screens/home_screen.dart
#	dogfooding/lib/widgets/settings_menu.dart
#	packages/stream_video/CHANGELOG.md
#	packages/stream_video/lib/src/models/call_preferences.dart
#	packages/stream_video/lib/src/models/models.dart
#	packages/stream_video_flutter/CHANGELOG.md
@Brazol Brazol changed the base branch from main to feat/codec-negotiation January 10, 2025 16:55
Comment thread packages/stream_video/lib/src/call/call_events.dart
Comment thread packages/stream_video/lib/src/models/call_closed_caption.dart Outdated
Copy link
Copy Markdown
Contributor

@d3xvn d3xvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feat/codec-negotiation to main January 15, 2025 10:49
# Conflicts:
#	dogfooding/lib/screens/home_screen.dart
#	packages/stream_video/lib/src/call/call.dart
#	packages/stream_video/lib/src/call/session/call_session.dart
#	packages/stream_video/lib/src/models/call_preferences.dart
#	packages/stream_video/lib/src/models/models.dart
#	packages/stream_video/lib/src/sfu/data/events/sfu_event_mapper_extensions.dart
#	packages/stream_video/lib/src/webrtc/rtc_manager.dart
#	packages/stream_video_flutter/CHANGELOG.md
@Brazol Brazol merged commit 023408b into main Jan 15, 2025
@Brazol Brazol deleted the feat/closed-captions branch January 15, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants