Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: AGP 8 compatibility #820

Merged
merged 6 commits into from
Jan 8, 2025
Merged

chore: AGP 8 compatibility #820

merged 6 commits into from
Jan 8, 2025

Conversation

Brazol
Copy link
Contributor

@Brazol Brazol commented Jan 2, 2025

This pull request includes several updates to the Android build configurations and dependency versions across multiple files. The main changes involve migrating from the old buildscript and apply plugin syntax to the newer plugins block, as well as updating various dependencies to their latest versions.

Build Configuration Updates:

  • Migrated from buildscript and apply plugin to the plugins block in dogfooding/android/app/build.gradle, packages/stream_video_flutter/android/build.gradle, and packages/stream_video_push_notification/android/build.gradle. [1] [2] [3]
  • Updated settings.gradle files to include Flutter plugin management and repository configurations. [1] [2] [3]

Dependency Updates:

  • Updated Firebase and other dependencies in dogfooding/pubspec.yaml to their latest versions. [1] [2]
  • Updated the thermal dependency in packages/stream_video/pubspec.yaml.

Code Simplification:

  • Replaced whereNotNull() with nonNulls in open_api_extensions.dart and lobby_view.dart. [1] [2]

Manifest File Updates:

  • Removed the package attribute from various AndroidManifest.xml files to simplify the manifest structure. [1] [2] [3] [4] [5] [6] [7]

@Brazol Brazol mentioned this pull request Jan 2, 2025
@Brazol Brazol marked this pull request as ready for review January 8, 2025 10:47
@Brazol Brazol requested a review from a team as a code owner January 8, 2025 10:47
Copy link
Member

@xsahil03x xsahil03x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brazol Brazol merged commit f78f88b into main Jan 8, 2025
5 checks passed
@Brazol Brazol deleted the chore/AGP-8-compatibility branch January 8, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants