Update chunk loading for MCPL changes #5818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclipseisoffline
force-pushed
the
data-palette-fix
branch
from
4fe864c to
c217522
Compare
onebeastchris
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the way Geyser loads chunks to incorporate for the changes made in MCProtocolLib#910. This should resolve some issues when loading chunks with a huge variety of blocks, where global data palettes are used.
This PR depends on the changes made in MCProtocolLib#910 to build.
Related issues that might be resolved are #5360 and #4501.
This PR has been tested in a normal Minecraft world, and in a world with chunks with a lot of different block states. Chunks seem to load fine, and errors printed in the aforementioned issues no longer appear.