Fix Java player skins not rendering on Bedrock when texture signature is absent#6487
Closed
rozqn wants to merge 1 commit into
Closed
Fix Java player skins not rendering on Bedrock when texture signature is absent#6487rozqn wants to merge 1 commit into
rozqn wants to merge 1 commit into
Conversation
PlayerEntity requested signed textures via getTextures(true), while every other call site (SkinManager, AvatarEntity) uses getTextures(false). When a profile's textures property has no signature, getTextures(true) throws, textures is set to null, and the player falls back to the default skin for Bedrock viewers.
Member
|
This is intentional, unless the method throws an exception that we don't catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PlayerEntity'sGameProfileconstructor callsprofile.getTextures(true), which requires a valid texture signature. Every other texture call site usesfalse:skin/SkinManager.java→profile.getTextures(false)entity/type/player/AvatarEntity.java→profile.getTextures(false)When a player's
texturesproperty has no signature (signature=null),getTextures(true)throws, thecatchsetstextures = null, and that player renders as the default (Steve) skin for Bedrock viewers.This reproduces consistently on Minecraft Java 26.2 (tested via the #6452 preview build): Java players' profiles arrive with the texture value present but
signature=null, so all Java players show as default skins to Bedrock players.Debug log:
Fix
Use
profile.getTextures(false)inPlayerEntity, matching the other call sites. The skin/cape URLs are still present and usable without signature verification.Testing
Built and ran on a Paper 26.2 server with Geyser + Floodgate. Java players' skins and capes now render correctly for Bedrock players.