Change logger to a static reference and add some debugging commands#6513
Draft
Novampr wants to merge 4 commits into
Draft
Change logger to a static reference and add some debugging commands#6513Novampr wants to merge 4 commits into
Novampr wants to merge 4 commits into
Conversation
Camotoy
reviewed
Jul 9, 2026
|
|
||
| private void executeHeapDump(CommandContext<GeyserCommandSource> context) { | ||
| try { | ||
| Path path = this.geyser.configDirectory().resolve("debug_heapdump.hprof"); |
Member
There was a problem hiding this comment.
Would we want to mark this by date (maybe also throw them in a folder) so multiple can be created without overwriting existing ones?
Contributor
Author
There was a problem hiding this comment.
This could be a good idea, but these heapdumps are already really big, I'm not sure we want a system where people can make a bunch, if they need multiple they can just move the file
Camotoy
reviewed
Jul 9, 2026
|
|
||
| import lombok.AllArgsConstructor; | ||
| import org.checkerframework.checker.nullness.qual.NonNull; | ||
| import org.geysermc.geyser.GeyserLogger; |
Contributor
Author
There was a problem hiding this comment.
Ah, left over import, I was trying to debug an issue with permissions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR; Any reference to GeyserImpl#getLogger() has been replaced with GeyserLogger#get() (A static method), this prevents the boilerplate of
GeyserImpl.getInstance().getLogger(), this should help to improve the length of logging line, it also improves debug logging by a bit.Other than that, this PR introduces some handy debugging commands, allowing you to add session debug flags that will apply when a user joins, currently there is only three:
These can be enabled via
/geyser debug player options [xuid] [option_name].There are also the following commands:
/geyser debug logging [enabled]/geyser debug heapdump [live]