Fix potent sulfur block entity id#6516
Merged
onebeastchris merged 1 commit intoJul 8, 2026
Merged
Conversation
Novampr
approved these changes
Jul 8, 2026
onebeastchris
approved these changes
Jul 8, 2026
Novampr
added a commit
that referenced
this pull request
Jul 10, 2026
* Initial changes * Exclude NeoForge temporarily * closer to compile?? * Start updating gametests, update mappings * Temporarily disable < 26.30, slimes are now ageable * Mention re-running datagen as a tip on how to fix the minecraft version gametest, adjust modrinth gameversions * Re-run datagen * Implement sulfur cube, fix team color check, add new attributes, enable older versions again * mention that mcpl could be outdated in gametests * Include neoforge again * Fix: move BedBlockEntityTranslator code into BedBlock * Fix: sulfur cube metadata translator order, re-run gametest datagen * Add component hasher and gametest for sulfur_cube_content component * Fix backport mappings for blocks * Fix backport mappings for blocks, again Remove state from potent sulfur in backport mapping Fix minimal string usage Co-authored-by: Eclipse <eclipse@eclipseisoffline.xyz> * Fix: load default data components before block mappings * Fix tests, bump MCPL * Correctly send sulfur cube contents, fix sulfur cube size * Cloud back to SNAPSHOT * Apply resolvable default item components to every Item (#6375) * Re-work ResolvableComponent/ComponentCache to be applied to every Item * Load resolvable registry components from to-be-generated mappings * Support loading holder set resolvable components, target mappings with newly generated file * Fix tests * Abstract ComponentCache with ResolvableComponentGetter and EMPTY implementation * Proper handling of PROVIDES_TRIM_MATERIAL in TrimRecipes * Address reviews * Target latest 26.2 mappings * Update fabric.mod.json and neoforge.mods.toml files * Fix sulfur cubes sizes and display * Revert mappings * Key the bedrock archetypes * Fix: always clone baseComponents in Item#gatherComponents * Remove temporary fix in gametest * Fix unit tests, use timestamped cloud version * Actually target the right cloud timestamped builds * Fix: Team colors suggestions * Don't send swing packets to the server while in spectator mode (#6461) * Automate the Minecraft version in the Fabric and NeoForge mod metadata (#6459) * Guard new attributes behind version checks * Fix: properly load resolvable holder components that are stored as Integer in MCPL, write gametest for it * Fix: this time with the new generated gametests! * Fix integrated server mixin * Add support for spectating entities on Bedrock (#6470) * Support spectating entities on Bedrock * Move spectator camera follow to the session tick and use the correct invisibility flag - Run the camera follow from GeyserSession#tick() instead of the auth-input translator - Use RENDER_WHEN_INVISIBLE instead of the redundant HIDDEN_WHEN_INVISIBLE so the first-person hide also covers overlays like spider eyes - Fix the input-suppression comment to point at InputCache's position-reminder note * Address review feedback for entity spectating - Mark spectatedEntity @nullable and make the spectate mode an enum - Hide RENDER_WHEN_INVISIBLE only on the entities that set it (spider, shulker) - Move the jump view-cycle into InputCache and drop the redundant sneak handling - Keep sending the client tick-end while spectating - Suppress the spectated entity's nametag - Send an empty spectator action on a no-entity left-click, matching the vanilla client - Clear the camera on stop so the F5 perspective toggle is restored * Fix spectate camera release on reconnect and player eye height * Custom waypoint style API (and mappings) (#6406) * Implement basic custom waypoint API * Refactor reading of custom mappings * Implement reading of waypoint style mappings * Fix imports in BlockMappingsReader_v1 * Fix imports again (for real this time) * Address some reviews * Write Javadocs! * Tiny bit more Javadoc for VanillaBuilder * Move to session-based custom waypoint styles * Resolve reviews, fix tests * More more more reviews * Add shorthand vanillaLike method, log registered waypoint styles through mappings, fix UOE by not making waypoint style registry unmodifiable * Properly handle suspicious effect holders in MooshroomEntity#mobInteract * Proper world border collision and minor visual fixes. (#6385) * Initial work on better world border. * Cleanup code. * Don't let player collide with the border if the border is resizing. * Avoid respawning entity if possible. * Address review. * Address review. * Feature: Custom Entity API (#6010) * Start working on custom entity API (for real this time) * Split EntityDefinition up into EntityDefinition and VanillaEntityDefinition, create GeyserEntityType, target custom entities MCPL * Allow creating custom entity types from API * Further refactor EntityDefinition, create a Base class * Work on exposing custom entity definitions in the API * Add EntityDefinition#is * Implement CustomEntityDefinition, part one * Move CustomEntityDefinition into custom package * CustomEntityDefinition should extend GeyserEntityDefinition * Separate BedrockEntityDefinition from Entity classes * EntityDefinition -> EntityTypeDefinition * Continue splitting bedrock entities from java types * Width, height and offset should be tied to the Java entity type; and can now be modified in the ServerSpawnEntityEvent * More work on events, closer to working * Fix startup * Expose geyserId in API, add SessionAttachParrotsEvent * Rename SessionAttachParrotsEvent -> ServerAttachParrotsEvent, fill in API Javadocs * Apply some suggestions * Another couple changes, start designing an entity data system to set scale/variant/height/width and so forth * Api design goes brrr * Implement dirty entities to send updates once a tick * Fix NPE in test * Attempt to add feature branch publishing * API polishing; properly initialize height/width * Refactor: unify offset handling, always store Java entity position * Remove unused offsets * Remove debug print, validate that entity definitions have been registered, setup publishing * Set up feature branch publishing and vertical offset applying * correct javadoc * Change entity definition log level to debug for missing definitions (#6042) * Fix villager inventories not showing up * Fix interaction range check * Expose entity hitboxes in API, store bedrock position to avoid re-calculation * Minor cleanup * Log unknown implementations of GeyserEntityDefinition * Use position setter instead of directly setting entity position * Fix client crashing related to sending & unlocking smithing recipes * Merge upstream * Fix hitbox querying, fix offset handling for boats * Fix entity lerping * Remove bedrockPosition variable again, simpler to only store one source of truth * Address issues * Bump mcpl * make it build again * Partially address review * fix le test * Fix: ResourcePackClientResponsePacket's may contain empty pack lists in the send_packs case * Fix debug log formatting calls * Minor fixes, reviews, etc * Support setting empty hitbox * Reviews and comments * Improve height / width handling This will be later reworked to allow setting a height + width combo that accounts for the entity pose. For now, it's a general override * Allow custom height / width to be 0 * Likely fix entity registration * Reduce diff, fix issue related to odd entity movement * Work around pistons creating ghost blocks * Feature: Expose basic seat offset / update entity passengers event * Fix tests * Temporarily revert "Fix: hide living entity name when it is a vehicle (#6290)" This reverts commit 3e91129. * Fix: sent bogus furnace recipes when none are sent by the server Remove debug exception Fix: client crash because no furnace recipes are sent # Conflicts: # core/src/main/java/org/geysermc/geyser/translator/protocol/java/JavaRecipeBookAddTranslator.java * Update to 26.1 * Update to jspecify conform nullability annotations * Fix test, use a fixed snapshot build * Fix build * Implement new geyser entity data override system * Address reviews * Support more entity data types * Revert "Temporarily revert "Fix: hide living entity name when it is a vehicle (#6290)"" This reverts commit 60f0bb5. * Revert initial changes for supporting non-vanilla entities * le ✨ javadocs ✨ * Misc improvements: Javadocs, some structural fixes * Improve entity data system by using EntityDataBehaviorRegistry, improve some data type javadocs * Fix: IdentifierImpl hacks * Mark API as experimental * Add debugging logs, smaller fixes to armor stand entity * Document remaining entity data types * this is aktschually unmodifiable * mhm this was supposed to be pushed * Update hitbox handling to resolve to-do * Differentiate between override and value in the API, improve offset handling in API * Include number of custom entities in the API * Apply suggestions from code review Co-authored-by: chris <github@onechris.mozmail.com> * Merge fixes * Add read/write lock for entity cache to allow safe off-thread entity lookups * dirtyMetadata -> metadata The class is no longer just a wrapper for metadata, but also handles API overrides / tracks entity data exposed in the API * Apply suggestion --------- Co-authored-by: Eclipse <eclipse@eclipseisoffline.xyz> Co-authored-by: Pierpaolo Coletta <pierpi0900@gmail.com> * Fix baby sulfur cube sizes * Fix mapping sub-module (my bane) * Fix invisible beds and centralize Bedrock-only block entity tag updates (#6514) * Fix potent sulfur block entity id (#6516) * Bump mappings * getEntities -> getEntitiesUnsafe to indicate direct access * Reapply "Adventure 5.0.0" This reverts commit 2d82fbe. * Initial changes: drop adventure-platform-bungee, update to 5.2.0 * Target cloud-beta 17 * temporary hack around velocity not being updated to 5.x adventure * Remove BungeeCord ping passthrough debug * Revert Velocity adventure 5 hack * Revert hack fully * Remove import * Bump supported versions --------- Co-authored-by: Novampr <auroranova8756@gmail.com> Co-authored-by: Eclipse <eclipse@eclipseisoffline.xyz> Co-authored-by: oxy <gamingnoob681@gmail.com> Co-authored-by: darkcupid412 <darkcupid412@gmail.com> Co-authored-by: Pierpaolo Coletta <pierpi0900@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.