Skip to content

Add trail particle support #6517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onebeastchris merged 1 commit into from
Jul 8, 2026
+22 −0
Merged

Add trail particle support #6517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ...java/org/geysermc/geyser/translator/protocol/java/level/JavaLevelParticlesTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.geysermc.mcprotocollib.protocol.data.game.level.particle.DustParticleData;
import org.geysermc.mcprotocollib.protocol.data.game.level.particle.ItemParticleData;
import org.geysermc.mcprotocollib.protocol.data.game.level.particle.Particle;
import org.geysermc.mcprotocollib.protocol.data.game.level.particle.TrailParticleData;
import org.geysermc.mcprotocollib.protocol.data.game.level.particle.VibrationParticleData;
import org.geysermc.mcprotocollib.protocol.data.game.level.particle.positionsource.BlockPositionSource;
import org.geysermc.mcprotocollib.protocol.data.game.level.particle.positionsource.EntityPositionSource;
Expand Down Expand Up @@ -202,6 +203,27 @@ public void translate(GeyserSession session, ClientboundLevelParticlesPacket pac
return particlePacket;
};
}
case TRAIL -> {
TrailParticleData data = (TrailParticleData) particle.getData();
int dimensionId = DimensionUtils.javaToBedrock(session);
Vector3f target = data.target().toFloat();
int rgbData = data.color();
float red = ((rgbData >> 16) & 0xFF) / 255f;
float green = ((rgbData >> 8) & 0xFF) / 255f;
float blue = (rgbData & 0xFF) / 255f;
float lifetime = Math.max(data.duration(), 1) / 20f;
return (position) -> {
Vector3f direction = target.sub(position);
float distance = direction.length();
Vector3f normalized = distance > 0 ? direction.div(distance) : Vector3f.ZERO;
SpawnParticleEffectPacket particlePacket = new SpawnParticleEffectPacket();
particlePacket.setIdentifier("minecraft:creaking_heart_trail");
particlePacket.setDimensionId(dimensionId);
particlePacket.setPosition(position);
particlePacket.setMolangVariablesJson(Optional.of("[{ \"name\": \"variable.direction\", \"value\": { \"type\": \"member_array\", \"value\": [{\"name\": \".x\", \"value\": { \"type\": \"float\", \"value\": " + normalized.getX() + "}},{\"name\": \".y\", \"value\": {\"type\": \"float\", \"value\": " + normalized.getY() + "}},{\"name\": \".z\", \"value\": {\"type\": \"float\", \"value\": " + normalized.getZ() + "}}]}},{ \"name\": \"variable.color\", \"value\": { \"type\": \"member_array\", \"value\": [{\"name\": \".r\", \"value\": { \"type\": \"float\", \"value\": " + red + "}},{\"name\": \".g\", \"value\": {\"type\": \"float\", \"value\": " + green + "}},{\"name\": \".b\", \"value\": {\"type\": \"float\", \"value\": " + blue + "}}]}},{ \"name\": \"variable.max_lifetime\", \"value\": { \"type\": \"float\", \"value\": " + lifetime + "}},{ \"name\": \"variable.particle_initial_speed\", \"value\": { \"type\": \"float\", \"value\": " + (distance / lifetime) + "}}]"));
return particlePacket;
};
}
default -> {
ParticleMapping particleMapping = Registries.PARTICLES.get(particle.getType());
if (particleMapping == null) { //TODO ensure no particle can be null
Expand Down
Loading