Implement static compression and encryption pipeline #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protocol/src/main/java/org/geysermc/mcprotocollib/network/Session.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/network/Session.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/network/Session.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/network/Session.java
Outdated
Show resolved
Hide resolved
…ion.java Co-authored-by: chris <[email protected]>
…ion.java Co-authored-by: chris <[email protected]>
…ion.java Co-authored-by: chris <[email protected]>
onebeastchris
approved these changes
Sep 11, 2024
Konicai
reviewed
Sep 12, 2024
protocol/src/main/java/org/geysermc/mcprotocollib/network/Session.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/network/tcp/TcpSession.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/protocol/ClientListener.java
Outdated
Show resolved
Hide resolved
|
nice btw :) |
…TcpSession.java Co-authored-by: Konicai <[email protected]>
Konicai
reviewed
Sep 13, 2024
protocol/src/main/java/org/geysermc/mcprotocollib/protocol/MinecraftProtocol.java
Outdated
Show resolved
Hide resolved
Konicai
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds up on the static sizer and timeout PR: #833
The reason compression and encryption should be static is to avoid confusion about the pipeline dynamically changing. This also allows more customization by developers who want to use alternative compression algorithms like igzip.