Skip to content

Allow accessing backing class for a channel instead of only its factory #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2024
Merged

Allow accessing backing class for a channel instead of only its factory #859

merged 1 commit into from
Sep 17, 2024

Conversation

AlexProgrammerDE
Copy link
Contributor

Some netty libraries that are poorly coded only accept classes. Example: CloudburstMC/Network#42

@AlexProgrammerDE
Allow accessing backing class for a channel instead of only its factory
141cfe0 
Some netty libraries that are poorly coded only accept classes. Example: CloudburstMC/Network#42
@Camotoy
Copy link
Member

Camotoy commented Sep 10, 2024

How would you use this for your MCProtocolLib projects?

@AlexProgrammerDE
Copy link
Contributor Author

@Camotoy Like this: https://github.com/AlexProgrammerDE/SoulFire/blob/b629ea854ca35cd3b0fee8528ecff12477bda6cd/server/src/main/java/com/soulfiremc/server/protocol/netty/ViaClientSession.java#L127

@Konicai Konicai merged commit de6bbe5 into GeyserMC:master Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Konicai Konicai Konicai approved these changes

@onebeastchris onebeastchris onebeastchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexProgrammerDE @Camotoy @Konicai @onebeastchris