Skip to content

Implemented Clone for NamedFields#2

Merged
weiznich merged 2 commits intoGiGainfosystems:feature/dynamic_queryfrom
Razican:clone_field
Feb 5, 2020
Merged

Implemented Clone for NamedFields#2
weiznich merged 2 commits intoGiGainfosystems:feature/dynamic_queryfrom
Razican:clone_field

Conversation

@Razican
Copy link

@Razican Razican commented Feb 4, 2020

This implements std::clone::Clone for NamedFields, if the inner type is Clone. This allows chaining with #1, to easily do transformations in returned rows.

@weiznich
Copy link
Member

weiznich commented Feb 4, 2020

Is there any reason that requires a explicit Clone impl and cannot use the derive?

@Razican
Copy link
Author

Razican commented Feb 5, 2020

The reason was I didn't know the derive implementation was intelligent enough to do bounds checking xD
Fixed, and also implemented it for DynamicRow.

@Razican Razican requested a review from weiznich February 5, 2020 14:30
@weiznich weiznich merged commit d38b6ba into GiGainfosystems:feature/dynamic_query Feb 5, 2020
@Razican Razican deleted the clone_field branch March 9, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants