Feature/diesel 2.0#33
Merged
pgab merged 12 commits intofix_binary_double_byte_order_giga_head_cherriesfrom Dec 17, 2019
Merged
Conversation
…der_giga_head_cherries Fix binary double byte order giga head cherries
This unblocks removing this function from diesel itself
This is the first step to support fully dynamic select queries in diesel-oci
pgab
reviewed
Dec 12, 2019
Member
pgab
left a comment
pgab
left a comment
There was a problem hiding this comment.
I will run the tests and report back.
src/oracle/connection/mod.rs
Outdated
| begin | ||
| create_if_not_exists('CREATE TABLE "__DIESEL_SCHEMA_MIGRATIONS" ( | ||
| "VERSION" VARCHAR2(50) PRIMARY KEY NOT NULL, | ||
| "RUN_ON" TIMESTAMP with time zone DEFAULT sysdate not null\ |
Member
There was a problem hiding this comment.
The \ probably needs to be deleted.
pgab
requested changes
Dec 12, 2019
Member
pgab
left a comment
pgab
left a comment
There was a problem hiding this comment.
I cannot even compile it:
Compiling r2d2 v0.8.7
error: cannot find macro `log!` in this scope
--> /home/paul/.cargo/registry/src/github.com-1ecc6299db9ec823/r2d2-0.8.7/src/lib.rs:121:9
|
121 | error!("{}", error);
| ^^^^^^^^^^^^^^^^^^^^
|
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
error: aborting due to previous error
error: Could not compile `r2d2`.
geomaniac
reviewed
Dec 16, 2019
Member
geomaniac
left a comment
geomaniac
left a comment
There was a problem hiding this comment.
Apart from the little stray backslash that Paul commented on, I think this looks good 👍
pgab
approved these changes
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated branch that points to a recent diesel master branch with a few cherry picks, notably the following work in progress PR's are included:
Additionally some cleanup of the code base is done. I've removed unused files, simplified some things and improved the error handling in some places. Additionally this should unblock the usage of the dynamic querying feature sketched out here: diesel-rs/diesel-dynamic-schema#10.
Note: I've not run any tests yet, would be great if someone @giga-info could do that.