New: GraphProblem #115
Closed
New: GraphProblem #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 95.51% 95.32% -0.20%
==========================================
Files 34 34
Lines 1450 1453 +3
==========================================
Hits 1385 1385
- Misses 65 68 +3 ☔ View full report in Codecov by Sentry. |
Owner
|
The name GraphProblem is not accurate. We can
|
GiggleLiu
reviewed
Dec 4, 2024
| [deps] | ||
| BitBasis = "50ba71b6-fa0f-514d-ae9a-0916efc90dcf" | ||
| DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae" | ||
| Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4" |
| InteractiveUtils = "1" | ||
| MLStyle = "0.4" | ||
| PrettyTables = "2" | ||
| Printf = "1.11.0" |
Owner
There was a problem hiding this comment.
Please only specify the first nonzero digit in deps.
| MLStyle = "0.4" | ||
| PrettyTables = "2" | ||
| Printf = "1.11.0" | ||
| julia = "1.10" |
Owner
There was a problem hiding this comment.
Suggested change
| julia = "1.10" | |
| julia = "1" |
| The unit weight vector of length `n`. | ||
| """ | ||
| struct ZeroWeight <: AbstractVector{Int} |
Owner
There was a problem hiding this comment.
Remove ZeroWeight since it is not used.
Owner
|
Tests are much more important than source code. Please focus on adding more tests. |
Owner
|
Thanks for the PR, but I think we do not need this problem anymore (since it is a polynomial time solvable problem). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
GraphProblemclass