Integer programming solver #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to nzy/PointSlicer
…to nzy/PointSlicer
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 93.64% 93.84% +0.19%
==========================================
Files 38 39 +1
Lines 1590 1640 +50
==========================================
+ Hits 1489 1539 +50
Misses 101 101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GiggleLiu
reviewed
Mar 31, 2025
Project.toml
Outdated
| Graphs = "1" | ||
| InteractiveUtils = "1" | ||
| JuMP = "1" | ||
| LinearAlgebra = "1.11.0" |
Owner
There was a problem hiding this comment.
Suggested change
| LinearAlgebra = "1.11.0" | |
| LinearAlgebra = "1" |
| @testset "solvers" begin | ||
| include("solvers.jl") | ||
| end | ||
|
|
Owner
There was a problem hiding this comment.
IPSolverExt.jl should be included.
GiggleLiu
reviewed
Apr 1, 2025
ext/IPSolverExt.jl
Outdated
| return round.(Int, JuMP.value.(x)) | ||
| end | ||
|
|
||
| function minimal_constraints(nflavor::Int, set::Vector) |
ext/IPSolverExt.jl
Outdated
| JuMP.optimize!(model) | ||
|
|
||
| # Return the solution if feasible | ||
| if JuMP.termination_status(model) == JuMP.MOI.OPTIMAL |
Owner
There was a problem hiding this comment.
Maybe use @assert is_solved_and_feasible(model) "error message..."?
ext/IPSolverExt.jl
Outdated
| end | ||
| end | ||
|
|
||
| obj_sum = 0 |
ext/IPSolverExt.jl
Outdated
| end | ||
|
|
||
| obj_sum = 0 | ||
| for obj in objs |
Owner
There was a problem hiding this comment.
Objectives can have more than one variables. The current code will scilently break for Spinglass.
ext/IPSolverExt.jl
Outdated
| # Returns | ||
| - `Vector{Int}`: The indices of the subsets to choose. | ||
| """ | ||
| function minimal_set_cover(coverset::Vector{Int}, subsets::Vector{Vector{Int}}, optimizer, verbose::Bool=false) |
Owner
There was a problem hiding this comment.
We do not need it anymore. Maybe we can dispatch it to set covering problem solver.
GiggleLiu
approved these changes
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each integer programming constrain removes one infeasible local configuration.