Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean translation PR #4

Merged
merged 2 commits into from
Jun 20, 2021
Merged

Korean translation PR #4

merged 2 commits into from
Jun 20, 2021

Conversation

comiluv
Copy link
Contributor

@comiluv comiluv commented Jun 18, 2021

issue #3

@comiluv comiluv changed the title Translator metadata Korean translation PR Jun 18, 2021
@GillesArcas
Copy link
Owner

Hi! I see you have made a huge work on the translation file. Of course I am willing to accept the PR and make a 4.32 release with it. I would like first to check the status of the translation. Is it ok with the new file? If not, have you installed with the installer or used the portable version?

@comiluv
Copy link
Contributor Author

comiluv commented Jun 19, 2021

I checked with portable version 4.23 of drago and shows correctly (=as expected). For versions 4.30 and 4.31, as with issue #2, any translation doesn't render correctly in both portable and install versions, which I presume to be a UTF-8 decoding issue.

The translation is full human translation except I purposely skipped parts associated with file I/O because it seemed it would require more extensive testing to not mess translation up with script syntax and stuffs like that.

Also some other things I couldn't figure out what it does even though I referenced English version of the help file were omitted, for example there's Main Menu - View - Reference View. I loaded a database that's included in the package, then loaded some random game data from the preview and clicked 'Reference View' but nothing seemed to happen, so left it untranslated. There are some more parts like it in the translation but it's mostly functional and is comprehensible.

@GillesArcas GillesArcas merged commit e4a1fd1 into GillesArcas:master Jun 20, 2021
@GillesArcas
Copy link
Owner

Hi, PR accepted. Now the question is when to make a 4.32 with your translation and fixing your problem. I have two problems with that. First, I am currently traveling for three months (until beginning of September). I have a tiny computer with the development environment and I can compile and make a release but it is a little bit more complicated. And second, I see no issue from here and the UI seems correctly translated. For this reason, I am left with no clues for where to start.
Perhaps you could determine if it is a code issue or an install issue by installing portable versions for 4.23 and 4.31 and putting the exe file from 4.31 in 4.23 directory and see what happens, or exchange Languages directory , or things like that.
Tell me also if they are parts witch are correctly translated.
I am comparing the files from both versions to see if I find any reason for the bug without any idea until now. I am sorry to not being able to do more for the moment.

Image1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants