Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plan regulation table #13

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Add plan regulation table #13

merged 5 commits into from
Feb 15, 2024

Conversation

msorvoja
Copy link
Contributor

@msorvoja msorvoja commented Feb 8, 2024

Adds plan regulation table. Additional information (lisätiedon laji), plan_theme (kaavoitusteema) and lifecycle_status_date (elinkaaritilaX_pvm) codes are still WIP.

@msorvoja msorvoja requested a review from Rikuoja February 8, 2024 14:59
@msorvoja msorvoja self-assigned this Feb 8, 2024
Copy link
Contributor

@Rikuoja Rikuoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! The only thing I realized is that probably we need to allow regulations with empty units, numeric values and numeric ranges. This means we have to specify nullable=True in some of the mapped columns.

database/models.py Outdated Show resolved Hide resolved
database/models.py Outdated Show resolved Hide resolved
database/models.py Outdated Show resolved Hide resolved
database/base.py Outdated Show resolved Hide resolved
@Rikuoja Rikuoja merged commit b6174b6 into main Feb 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants