225 add dns record #234
Merged
225 add dns record #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehtojaa
reviewed
Mar 22, 2024
infra/README.md
Outdated
|
|
||
| ### Multi-factor authentication (MFA) | ||
|
|
||
| If you get a 403 error when deploying or destroying resources with terraform despite having configured a valid AWS | ||
| If you get a 403 error when running terraform despite having configured a valid AWS |
There was a problem hiding this comment.
Also sops will result 400 error without MFA, so maybe mention that as well?
lehtojaa
reviewed
Mar 22, 2024
infra/README.md
Outdated
|
|
||
| ### Multi-factor authentication (MFA) | ||
|
|
||
| If you get a 403 error when deploying or destroying resources with terraform despite having configured a valid AWS | ||
| If you get a 403 error when running terraform despite having configured a valid AWS | ||
| access key, you may need to set up MFA. Install both AWS CLI and jq, and make sure you have `aws` and `jq` in path. Execute the `[get-mfa-vars.sh](https://gist.github.com/mvaaltola/0abced5790401f2454444fb2ffd4acc0)` script with your AWS arn and your MFA access code, |
There was a problem hiding this comment.
I know it is not addition in this PR, but considering the instructions overall, it might clearer if explicitly stated that it is the aws arn related to the mfa device?
lehtojaa
reviewed
Mar 22, 2024
Rikuoja
force-pushed
the
225-add-dns-record
branch
from
0b35abf to
6283c7f
Compare
lehtojaa
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #225