Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

217 type of plan regulation group #241

Merged
merged 6 commits into from
Mar 7, 2024
Merged

217 type of plan regulation group #241

merged 6 commits into from
Mar 7, 2024

Conversation

Rikuoja
Copy link
Contributor

@Rikuoja Rikuoja commented Mar 6, 2024

Fix #217

@Rikuoja Rikuoja requested review from lehtojaa and msorvoja March 6, 2024 15:07
@msorvoja
Copy link
Contributor

msorvoja commented Mar 7, 2024 •
edited
Loading

Looks good! But shouldn't there be a relation between plan_regulation_group table and type_of_plan_regulation_group code table, right? Also, I just noticed that there isn't relation between organisation table and administrative_region code table.

@Rikuoja
Copy link
Contributor Author

Rikuoja commented Mar 7, 2024

Looks good! But shouldn't there be a relation between plan_regulation_group table and type_of_plan_regulation_group code table, right? Also, I just noticed that there isn't relation between organisation table and administrative_region code table.

Thanks @msorvoja ! Will add them both while I'm at it.

@Rikuoja Rikuoja merged commit 0bac436 into main Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehtojaa lehtojaa Awaiting requested review from lehtojaa

@msorvoja msorvoja Awaiting requested review from msorvoja

Assignees
No one assigned
Labels
None yet
Projects
OsKaTi - Ryhti
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add type of plan regulation group code list
2 participants
@Rikuoja @msorvoja