14 add additional date fields for lifecycle status events

[msorvoja]

Fix #14

@Rikuoja @lehtojaa I couldn't find English translations for all lifecycle events, so please let me know if you disagree with any of them.

[Rikuoja]

Fix #14

@Rikuoja @lehtojaa I couldn't find English translations for all lifecycle events, so please let me know if you disagree with any of them.

@msorvoja They are in English here, so you can use these terms https://koodistot.suomi.fi/codescheme;registryCode=rytj;schemeCode=kaavaelinkaari

[Rikuoja]

Looks good, but as per usual, let's do it another way after all!

Reworded the issue so that we should add a completely new table instead!

[Rikuoja]

Looks very good!

Perhaps we could also add, for completeness' sake, a test fixture for the new model in conftest.py, and a test function for all the relationships in test_models.py. Just rebase this on main to get all the other pytest fixtures in conftest.py and test_models.py so you can add your own.

For ease of testing, let's just test (for now) a lifecycle date that may refer to plan, plan regulation and plan proposition simultaneously.

Of course, the right way would be to test three lifecycle statuses that each only refer to one of the three tables, since that is the way they will be used in practice, but this will do. Later, if we need to add a constraint function that requires that only one of the three fields is filled, then this test must be rewritten.

So this would mean a function like

def test_lifecycle_date(
    session: Session,
    lifecycle_date_instance: models.LifeCycleDate,
    code_instance: codes.LifeCycleStatus,
    plan_instance: models.Plan,
    plan_regulation_instance: models.PlanRegulation,
    plan_proposition_instance: models.PlanProposition,
):
    # non-nullable lifecycle date relations
    assert (
        lifecycle_date_instance.lifecycle_status is code_instance
    )
    assert code_instance.lifecycle_dates == [
        lifecycle_date_instance
    ]
    # nullable lifecycle date relations
    assert (
        lifecycle_date_instance.plan is None
    )
    assert plan_instance.lifecycle_dates == []
    lifecycle_date_instance.plan = plan_instance
    assert (
        lifecycle_date_instance.plan_regulation is None
    )
    assert plan_regulation_instance.lifecycle_dates == []
    lifecycle_date_instance.plan_regulation = plan_regulation_instance
    assert (
        lifecycle_date_instance.plan_proposition is None
    )
    assert plan_proposition_instance.lifecycle_dates == []
    lifecycle_date_instance.plan_proposition = plan_proposition_instance
    session.flush()
    ...

and then after session.flush(), check that the lifecycle_date_instance has all three relations set, and all the other three instances have this lifecycle_date_instance in their lifecycle_dates list.

[msorvoja]

@Rikuoja I added the test function, test fixture and other changes you requested. Should be good to merge now!

[Rikuoja]

Looks very good!