Index fixes #405
Merged
Index fixes #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LKajan
commented
Dec 2, 2024
LKajan
commented
- Make ordering index composite with the parent. The ordering makes sense only within the parent.
- Make short name nullable - In my understanding short names are "mandartory" only in regulation_groups of land_use_areas.
- Make short names unique only within a plan, not globally
Order of just "ordering" column is not meaningful. Ordering takes always place inside a parent feature which should always be included in th queries.
Short names are unique only within the plan not globally.
LKajan
commented
Dec 2, 2024
database/test/conftest.py
Outdated
| unique: bool | ||
|
|
||
|
|
||
| ordering_index_by_table = { |
There was a problem hiding this comment.
@Rikuoja, I don't quite like defining the expected indexes manually like this. Do you have ideas how to avoid this?
Rikuoja
requested changes
Dec 2, 2024
Index definition includes all the information about the index so there's no need to test other columns from the pg_indexes table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.