Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress errors when deleting temp dir #42

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

Joonalai
Copy link
Contributor

This PR resolves #41 by suppressing PermissionError when trying to delete temporary QGIS configuration directory.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +1.15 🎉

Comparison is base (d81a06d) 54.66% compared to head (4a4cfec) 55.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   54.66%   55.81%   +1.15%     
==========================================
  Files           7        7              
  Lines         472      464       -8     
==========================================
+ Hits          258      259       +1     
+ Misses        214      205       -9     
Flag Coverage Δ
pytest 55.81% <66.66%> (+1.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pytest_qgis/pytest_qgis.py 53.62% <66.66%> (+0.95%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Joonalai Joonalai changed the title WIP: suppress errors when deleting temp dir Suppress errors when deleting temp dir Jun 26, 2023
Copy link
Contributor

@LKajan LKajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently the copyright text jumped a bit by accident.

I'm a bit unsure if suppressing this warning is the right solution. Since no big harm is made by this I'm ok to merge this if a new issue is created for finding a proper solution (revisit the order of closing and deleting things) and link to that issue commented as todo.

@Joonalai
Copy link
Contributor Author

Thanks for the feedback. I fixed the copyright comment and added a new issue addressing this problem #43.

@Joonalai Joonalai requested a review from LKajan June 29, 2023 08:30
src/pytest_qgis/pytest_qgis.py Show resolved Hide resolved
@Joonalai Joonalai force-pushed the 41-fix-permission-error branch from 18fbbda to 4a4cfec Compare June 29, 2023 12:25
@LKajan LKajan merged commit 6d73fa2 into GispoCoding:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PermissionError when running unit tests (QGIS 3.30, pytest-qgis 1.3.4)
3 participants