(#476) Add validation of input file path handler #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gep13
force-pushed
the
AdmiringWorm/issue476
branch
from
3456e6a to
4df7b48
Compare
This updates how arguments are parsed when attempting to create a new release. This disallows explicitly the use of a milestone, and an input file path in the same call. This is done as there was confusion on why specifying a input file path was not using the release notes specified. This should make it clearer to the caller what the issue is.
gep13
force-pushed
the
AdmiringWorm/issue476
branch
from
4df7b48 to
641cf22
Compare
|
@AdmiringWorm thank you very much for taking the time to fix this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates how arguments are parsed when attempting to create a new
release. This disallows explicitly the use of a milestone, and an input
file path in the same call.
Related Issue
fixes #476
Motivation and Context
This is done as there was confusion on why specifying a input file path
was not using the release notes specified. This should make it clearer
to the caller what the issue is.
How Has This Been Tested?
grm create --milestone 0.5.0 -i some-relase-notes.txtwith additional valid arguments.Screenshots (if appropriate):
Checklist: