(#495) Allow milestones without issues #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jericho
force-pushed
the
allow_milestone_without_issues
branch
from
329ce1d to
86ec74f
Compare
Jericho
force-pushed
the
allow_milestone_without_issues
branch
2 times, most recently
from
89be67c to
4c741ab
Compare
gep13
changed the title
gep13
force-pushed
the
allow_milestone_without_issues
branch
2 times, most recently
from
17a8115 to
9f64eb4
Compare
Jericho
force-pushed
the
allow_milestone_without_issues
branch
from
f6285e6 to
6a97712
Compare
This commit introduces a new configuration value in the GitReleaseManager.yaml file, which is disabled by default. When enabled, it will be used to control whether the creation of an "empty" release is allowed. This will make use of a new "empty" Scriban template, which will be introduced in the next commit.
gep13
force-pushed
the
allow_milestone_without_issues
branch
from
6a97712 to
a66c7ab
Compare
When creating a release a new template is used when a milestone does not have any associated issues AND the developer has indicated they want to allow milestones without issues. The decision on which template to use has had to be moved. It can still be overridden when required, but the calculated value is based on how many issues have been found, whether to include contributors, etc.
Due to the change to allow calculation of which template to use, it is no longer needed to pass in a template value. This is only needed when we specifically want/need to control which template is used.
Add information to the docs section for the new allow-milestone-without-issues option.
gep13
force-pushed
the
allow_milestone_without_issues
branch
from
a66c7ab to
c4cdc00
Compare
|
@Jericho thank you very much for getting this PR in, I really appreciate it! I have made a couple of small changes to it, in order to get it over the line, but this should be going out the door today, along with a change to target the latest .NET Framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow developers to specify whether they want to allow a release to be created even when the milestone is not associated with any issues.
Regarding #495