(#633) Update to latest NGitLab package version #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As answered here: https://stackoverflow.com/a/6792308/671491 The first project in the sln file is the one that is set as the default startup project when opened in Visual Studio. This prevents the need to manually set this once the solution is opened.
This addresses an issue which was seen when trying to close milestones using the GitLab provider. There would be an error thrown regarding being able to correctly serialize a number into an int32, since the number was too big. An upstream change was needed in NGitLab, so switch to usign to a long. There was a similar error when using GitHub, and a bump in the version of Octokit being used was required. This has been tested against a GitLab repository, and the close command which was previously failing is now working.
|
@gep13 thanks for getting this updated. Great work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses an issue which was seen when trying to close milestones
using the GitLab provider. There would be an error thrown regarding
being able to correctly serialize a number into an int32, since the
number was too big.
An upstream change was needed in NGitLab, so switch to usign to a long.
There was a similar error when using GitHub, and a bump in the version
of Octokit being used was required.
This has been tested against a GitLab repository, and the close command
which was previously failing is now working.
Related Issue
Fixes #633
Motivation and Context
An error was being thrown when attempting to use the
closecommand when doing releases.How Has This Been Tested?
The reproduction steps in #633 were followed both before and after this change was made.
Those steps were initially failing, and after this change was made, things were working again.
Screenshots (if appropriate):
N/A
Checklist: