convert nuget packages to use central package management

[arturcic]

Convert the nuget package management to the central package management

[gep13]

I am as sure as I can be that this is going to break some of the tooling that we have in this build, specifically the usage of Wyam for documentation generation, so I don't think we can remove these just now.

[gep13]

@arturcic can I ask how you made this changes in this PR?

The reason that I am asking is that your changes seem to have the same whitespace/line endings changes that we are seeing in the Dependabot PR's. I am not seeing these changes when I edit the files on my machine, so there must be something that is causing this to happen.

What are you using in terms of:

• Operating System
• IDE
• git version
• etc

If we can compare these things, it might help isolate what is going on.

Thanks

[arturcic]

I used Visual Studio in a VM on my Mac (meaning it's a Windows ARM64). I used the Upgrade Assistent extensions in Visual Studio to migrate to Central Package Management.
git version 2.44.0.windows.1

[arturcic]

I will keep only 1 commit for Central Package Management ( was trying to do more in this PR, but probably step by step approach would be better)

[gep13]

I am still hestitant to pull in these changes, because as soon as I do, I will get issues on my machine.

I really want to get to the bottom of this, as this will turn into a back and forth as we each make changes.

I have asked for some help from some people that might know more.

[arturcic]

sure no worries, please update this PR as you need, the idea is to centralize the package management and thus have the dependabot PRs changing only one file.

[gep13]

To rule something out, can you navigate to the folder where you have GRM cloned to, and then run the following:

git config core.autocrlf

What do you get back?

[arturcic]

git config core.autocrlf

The result is true

[mkevenaar]

Do you both use Editorconfig plugins? see .editorconfig

[gep13]

Yes, there is an editorconfig file in play here, but I don't believe that this is part of the issue. The changes that I am seeing are happening outside of an IDE. @AdmiringWorm and I went through and modified both the editorconfig file and gitattibutes file today, so they should be correct (or at least, as correct as we know about 😄)

[arturcic]

Do you both use Editorconfig plugins? see .editorconfig

I installed Visual Studio from scratch on that VM, added only the Upgrade Assistant
, I guess I'm using the VS defaults

[gep13]

git config core.autocrlf

The result is true

I am not convinced that this is part of the problem, since the entry in the .gitattributes file should take care of this, but just so that I point it out:

• https://markentier.tech/posts/2021/10/autocrlf-true-considered-harmful/
• https://www.edwardthomson.com/blog/git_for_windows_line_endings.html

[mkevenaar]

Do you both use Editorconfig plugins? see .editorconfig

I installed Visual Studio from scratch on that VM, added only the Upgrade Assistant

, I guess I'm using the VS defaults

Try installing or configuring that tool and recreate these changes. See if that solves the line endings.

[arturcic]

Do you both use Editorconfig plugins? see .editorconfig

I installed Visual Studio from scratch on that VM, added only the Upgrade Assistant
, I guess I'm using the VS defaults

Try installing or configuring that tool and recreate these changes. See if that solves the line endings.

which tool? where I can get it from?

[mkevenaar]

Do you both use Editorconfig plugins? see .editorconfig

I installed Visual Studio from scratch on that VM, added only the Upgrade Assistant

, I guess I'm using the VS defaults

Try installing or configuring that tool and recreate these changes. See if that solves the line endings.

which tool? where I can get it from?

https://learn.microsoft.com/en-us/community/content/how-to-enforce-dotnet-format-using-editorconfig-github-actions#3---formatting-your-code-locally

Editorconfig is installed by default in VS2022. Just check if it's enabled on your end

[arturcic]

It is enabled as in https://learn.microsoft.com/en-us/visualstudio/ide/create-portable-custom-editor-options?view=vs-2022#troubleshoot-editorconfig-settings

[arturcic]

@gep13 you ca try to install that extension on your machine and select one of the projects and Right-click>Upgrade and select

[arturcic]

You might see the same changes, or if a bit different you can update this PR with your version

[AdmiringWorm]

I had a look through the changed files, and from the looks of it there are no changes to any line endings, unlike what was previously said.

The changes has to do with the change from 4 spaces in the indentation to 2 spaces, and it probably have confused the web diff because of it.

There could be two reasons for the indentation change:

1. The Upgrade Assistant tool does not respect the editorconfig file (last time I used it, it ignored the file).
2. You initially had visual studio open with the old editorconfig file, then later switched to a new branch or updated commit without reloading VS (I have seen this happen from time to time that VS wouldn't refresh according to changes in the editorconfig).

[gep13]

LGTM!

[gep13]

@arturcic I have fixed this up locally, fixing the whitespace descrepancies.

Thanks for starting the work on this!

Going to get this merged in.

[arturcic]

@arturcic I have fixed this up locally, fixing the whitespace descrepancies.

Thanks for starting the work on this!

Going to get this merged in.

Sure, you're welcome