Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content source: auto-translation #557

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Content source: auto-translation #557

wants to merge 11 commits into from

Conversation

SamyPesse
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: 3dff188

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sourceId: source.sourceId,
compute: async (event, context) => {
const output =
event.type === 'content_compute_pages'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a switch + assertNever, so if we add an event type we will get an error. Or if for an unknown reason we pass an unexpected event at runtime.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default case maybe?

const translated = JSON.parse(result.choices[0].message.content!);
return translated.input;
} catch (error) {
throw new ExposableError('Failed to translate content: ' + (error as Error).message);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should support cause in ExposableError, not in this PR.

Comment on lines +59 to +67
{ label: 'English', id: 'en' },
{ label: 'French', id: 'fr' },
{ label: 'German', id: 'de' },
{ label: 'Italian', id: 'it' },
{ label: 'Japanese', id: 'ja' },
{ label: 'Korean', id: 'ko' },
{ label: 'Portuguese', id: 'pt' },
{ label: 'Russian', id: 'ru' },
{ label: 'Spanish', id: 'es' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

85 languages are supported by ChatGPT, let's add all of them! Why not restricting it to this list?

https://botpress.com/blog/list-of-languages-supported-by-chatgpt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants