-
Notifications
You must be signed in to change notification settings - Fork 80
Vaultrice voting integration #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
commit: |
Hi @adrai - thanks for putting this together! From first glance it looks like a very complex but useful integration. Can you please update your branch with the latest changes from After that I’ll hop in and look into testing this in some GitBook sites with you! |
Thank you @addisonschultz I've just rebased it ;-) |
@addisonschultz is there anything I can do to make the "Check integrations" green? |
706467a
to
ea4fa3a
Compare
Hi @adrai - apologies for the delay! We’re working out some CI issues on our end to pass the checks in this PR. |
9bfb488
to
017b0d0
Compare
@addisonschultz any update on this? or anything I need to to do from my side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Creates a new Vaultrice Voting integration for GitBook that allows embedding interactive voting widgets with real-time results using the @vaultrice/react-components library.
- Adds complete integration with React-based voting widget, configuration UI, and build system
- Implements webframe-based rendering architecture for secure iframe embedding
- Provides user-friendly block editor with JSON-based choice configuration
Reviewed Changes
Copilot reviewed 9 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
integrations/vaultrice-voting/vite.widget.config.ts | Vite configuration for building the widget bundle |
integrations/vaultrice-voting/tsconfig.json | TypeScript configuration extending GitBook's integration setup |
integrations/vaultrice-voting/src/widget.tsx | React widget implementation with iframe communication and voting component |
integrations/vaultrice-voting/src/vote-block.tsx | GitBook block component with configuration UI and webframe rendering |
integrations/vaultrice-voting/src/index.ts | Main integration entry point with HTTP handlers and script serving |
integrations/vaultrice-voting/package.json | Package configuration with dependencies and build scripts |
integrations/vaultrice-voting/gitbook-manifest.yaml | Integration manifest with metadata and configuration schema |
integrations/vaultrice-voting/CHANGELOG.md | Initial changelog entry |
.prettierignore | Excludes generated script file from formatting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@addisonschultz let me know if there's anything else I can do ;-) |
Hi @adrai ! We’re still working on wrangling this CI issue - but in the meantime, your integration should be usable in the sense that you can install it at https://app.gitbook.com/integrations/vaultrice-voting-widget ! I don’t have a timeline on us fixing this (we’re actively looking into this though!) - and after we get the CI fixed, I’ll finish the review and get the integration verified so it shows up in our app. In the meantime, you can already use it though! |
Summary
Creates a new GitHub Conversations integration that syncs GitHub Discussions to GitBook conversations.
Key feature
Uses the @vaultrice/react-components Voting component
Additional Info
Original code copied from here.