Skip to content

Conversation

adrai
Copy link

@adrai adrai commented Sep 4, 2025

Summary

Creates a new GitHub Conversations integration that syncs GitHub Discussions to GitBook conversations.

Key feature

Uses the @vaultrice/react-components Voting component

Additional Info

Original code copied from here.

Copy link

changeset-bot bot commented Sep 4, 2025

⚠️ No Changeset found

Latest commit: ddb9e6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Sep 4, 2025

Open in StackBlitz

bun add https://pkg.pr.new/GitbookIO/integrations/@gitbook/api@971

commit: ddb9e6c

@addisonschultz
Copy link
Collaborator

Hi @adrai - thanks for putting this together! From first glance it looks like a very complex but useful integration. Can you please update your branch with the latest changes from main? We’ve merged something recently that should allow the tests to pass.

After that I’ll hop in and look into testing this in some GitBook sites with you!

@adrai
Copy link
Author

adrai commented Sep 5, 2025

Hi @adrai - thanks for putting this together! From first glance it looks like a very complex but useful integration. Can you please update your branch with the latest changes from main? We’ve merged something recently that should allow the tests to pass.

After that I’ll hop in and look into testing this in some GitBook sites with you!

Thank you @addisonschultz I've just rebased it ;-)

@adrai
Copy link
Author

adrai commented Sep 6, 2025

@addisonschultz is there anything I can do to make the "Check integrations" green?

@adrai adrai force-pushed the main branch 3 times, most recently from 706467a to ea4fa3a Compare September 9, 2025 19:11
@addisonschultz
Copy link
Collaborator

Hi @adrai - apologies for the delay! We’re working out some CI issues on our end to pass the checks in this PR.

@adrai adrai force-pushed the main branch 4 times, most recently from 9bfb488 to 017b0d0 Compare September 15, 2025 12:59
@adrai
Copy link
Author

adrai commented Sep 18, 2025

@addisonschultz any update on this? or anything I need to to do from my side?

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Creates a new Vaultrice Voting integration for GitBook that allows embedding interactive voting widgets with real-time results using the @vaultrice/react-components library.

  • Adds complete integration with React-based voting widget, configuration UI, and build system
  • Implements webframe-based rendering architecture for secure iframe embedding
  • Provides user-friendly block editor with JSON-based choice configuration

Reviewed Changes

Copilot reviewed 9 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
integrations/vaultrice-voting/vite.widget.config.ts Vite configuration for building the widget bundle
integrations/vaultrice-voting/tsconfig.json TypeScript configuration extending GitBook's integration setup
integrations/vaultrice-voting/src/widget.tsx React widget implementation with iframe communication and voting component
integrations/vaultrice-voting/src/vote-block.tsx GitBook block component with configuration UI and webframe rendering
integrations/vaultrice-voting/src/index.ts Main integration entry point with HTTP handlers and script serving
integrations/vaultrice-voting/package.json Package configuration with dependencies and build scripts
integrations/vaultrice-voting/gitbook-manifest.yaml Integration manifest with metadata and configuration schema
integrations/vaultrice-voting/CHANGELOG.md Initial changelog entry
.prettierignore Excludes generated script file from formatting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@adrai
Copy link
Author

adrai commented Sep 24, 2025

@addisonschultz let me know if there's anything else I can do ;-)

@addisonschultz
Copy link
Collaborator

Hi @adrai ! We’re still working on wrangling this CI issue - but in the meantime, your integration should be usable in the sense that you can install it at https://app.gitbook.com/integrations/vaultrice-voting-widget !

I don’t have a timeline on us fixing this (we’re actively looking into this though!) - and after we get the CI fixed, I’ll finish the review and get the integration verified so it shows up in our app.

In the meantime, you can already use it though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants