fix: replace regex url validation with validator library #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barabazs
force-pushed
the
fix/improve-url-detection
branch
from
f38b5bd to
ebca60f
Compare
|
Friendly 🆙 |
|
Thanks @Barabazs! |
GjjvdBurg
added a commit
that referenced
this pull request
Jan 4, 2025
* Add support for uploading through USB (thanks to @sachiniyer in #155) * Add support for forcing source type (thanks to @Barabazs in #153) * Migrate regex url validation to validators library (thanks to @Barabazs in #152) * Update the Dockerfile (thanks to @Barabazs in #150) * Update documentation to link to rmapi fork (thanks to @Barabazs in #149) * Various fixes to broken providers and unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the regex url validation with the validators library.
The current regex did not cover enough/all valid URLs.
Closes #151