-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CPD and make ICP Python-based #701
Draft
rhugonnet
wants to merge
30
commits into
GlacioHack:main
Choose a base branch
from
rhugonnet:add_cpd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ongoing...
This PR adds Coherent Point Drift (CPD) coregistration, and modifies Iterative Closest Point (ICP) coregistration to be fully Python-based. This allows to remove the (heavy) OpenCV dependency, and call consistent optimizer/parameters compared to other methods.
As both methods are point registration, a new preprocessing shared by both methods has to be introduced, which is why they are in the same PR.
This PR takes over #581, which is closed. It is possible thanks to #530 to use the same core functions as other coregs.
Implementation details
ICP
This PR adds many options of ICP to ensure the best accuracy and performance, equal to that of OpenCV or Open3D's implementation (tested outside of xDEM, see details on this further below).
Those are:
scipy.optimize.least_squares
).CPD
This PR adds a fully NumPy-based implementation of CPD relying on pycpd's rigid implementation: https://github.com/siavashk/pycpd/blob/master/pycpd/rigid_registration.py.
CPD has trouble for unscaled data, so we need to add scaling options to xDEM to properly use it.
This is ongoing, see to-do below...
Benchmarking our Python ICP, and more?
In order to benchmark that our ICP performs as well as other algorithms out there, both in terms of accuracy and speed, I've separately written a Python module that runs ICP from OpenCV, Open3D, and other packages. This is currently on a separate repository (as we don't want these dependencies in xDEM).
Should we add that new module into a
xdem-benchmark
or similar, that can punctually install/run other packages and xDEM, to compare the performance of all these algorithms?We could consider adding other algorithms to this repo, for instance the ICP of py4dgeo (#504), or of libpointmatcher (potentially via ASP too): #11.
But also other algorithms, in time, if we want (check CPD implementation, etc).
TO-DO to finalize
Resolves #100
Resolves #483