Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#697 add capability to expend env variable in username #698

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

QuentinBrun
Copy link
Contributor

I hope this help.

@JoC0de
Copy link
Collaborator

JoC0de commented Feb 14, 2025

@QuentinBrun thanks for the contribution.
I am not sure if we can implement it in this easy way. The UserName property should be renamed to SavedUserName to be consistent with the SavedPassword property. But it affects the public interface INugetPackageSource witch impacts our plugin system.
@igor84 what is your opinion on this?

@igor84
Copy link
Collaborator

igor84 commented Feb 14, 2025

Our plugin system is still very young so I would be surprised if anyone beside me is using it :) and since I don't use username in my plugin and configuration it wouldn't really break anything... So I would be ok with changing it.

@JoC0de JoC0de merged commit 439754a into GlitchEnzo:master Feb 15, 2025
8 checks passed
@QuentinBrun
Copy link
Contributor Author

Hi, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add capability to expend environment variables in username - for packageSourceCredentials
3 participants