Skip to content

Conversation

@zbraiterman
Copy link
Contributor

I have added a directory, called "resources", for images and have added a Glow logo to that directory.

Copy link
Contributor

@plotnick plotnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather these diagrams go in a directory like dapps/images, since they're related to those dapps. They definitely should not be in the top-level directory. There's also a spurious glow executable (?).

@zbraiterman
Copy link
Contributor Author

I'd rather these diagrams go in a directory like dapps/images, since they're related to those dapps. They definitely should not be in the top-level directory. There's also a spurious glow executable (?).

Thanks. I’ll modify the directory, accordingly and will remove the spurious glow executable. 

Also, to confirm, do the diagrams look good to you, or do you think any of them should be modified/updated?

@zbraiterman zbraiterman mentioned this pull request Nov 11, 2021
@zbraiterman
Copy link
Contributor Author

I've just submitted pull request #414 to apply the changes @plotnick has requested.

@fare
Copy link
Contributor

fare commented Nov 16, 2021

I still don't understand why these images are going here rather than in the mooc or glow-lang.org... We should probably reorganize these repositories a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants