Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct misleading description of SX action #1886

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

Kaligula0
Copy link
Contributor

Correct misleading description about creating Scheduled Transaction. Using this action on a user-created transaction creates a new Scheduled Transaction, but using this action on a transaction that was created by Schedule just opens its Scheduled Transaction.

Correct misleading description about creating Scheduled Transaction. Using this action on a user-created transaction creates a new Scheduled Transaction, but using this action on a transaction that was created by Schedule just opens its Scheduled Transaction.
@@ -294,7 +294,7 @@
<item>
<attribute name="label" translatable="yes">Sche_dule…</attribute>
<attribute name="action">GncPluginPageRegisterActions.ScheduleTransactionAction</attribute>
<attribute name="tooltip" translatable="yes">Create a Scheduled Transaction with the current transaction as a template</attribute>
<attribute name="tooltip" translatable="yes">Create a Scheduled Transaction with the current transaction as a template or edit the Scheduled Transaction that current transaction was created by</attribute>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please finish the sentence with a full stop .!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? I know the grammar, but there are no full stops at the end of strings/sentences in this file (except for the line 99).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice, if you fixed all then.
In the times of DOS almost nobody applied them, but today weblate [old message] is sending us warnings.

@code-gnucash-org code-gnucash-org merged commit 622cc53 into Gnucash:stable Mar 17, 2024
3 of 4 checks passed
@jralls
Copy link
Member

jralls commented Mar 17, 2024

Thanks!

@Kaligula0 Kaligula0 deleted the SX-action-description branch March 17, 2024 14:24
@@ -846,7 +846,7 @@
<property name="can-focus">False</property>
<property name="label" translatable="yes">Sche_dule…</property>
<property name="action-name">GncPluginPageRegisterActions.ScheduleTransactionAction</property>
<property name="tooltip-text" translatable="yes">Create a Scheduled Transaction with the current transaction as a template</property>
<property name="tooltip-text" translatable="yes">Create a Scheduled Transaction with the current transaction as a template or edit the Scheduled Transaction that current transaction was created by</property>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full stop still missing.
I will fix it despite string freeze, because it will be the same string as we already have.

Copy link
Contributor Author

@Kaligula0 Kaligula0 Mar 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! My Regex didn't fix all of them, because I didn't notice there are <attributes> as well as <properties>. Now I found even more full stops, and fixed them all, I think → #1895.

@Kaligula0 Kaligula0 restored the SX-action-description branch March 23, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants