Add support for XR_META_spatial_entity_mesh to get global scene mesh #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
force-pushed
the
meta-spatial-entity-mesh
branch
from
2796620 to
863216b
Compare
m4gr3d
requested changes
Apr 18, 2024
dsnopek
force-pushed
the
meta-spatial-entity-mesh
branch
2 times, most recently
from
12adf7b to
3e9e485
Compare
m4gr3d
approved these changes
Apr 22, 2024
| @@ -98,7 +98,7 @@ void OpenXRFbSceneExtensionWrapper::_on_instance_destroyed() { | |||
| } | |||
|
|
|||
| const PackedStringArray &OpenXRFbSceneExtensionWrapper::get_supported_semantic_labels() { | |||
| static PackedStringArray semantic_labels = String(SUPPORTED_SEMANTIC_LABELS).split(","); | |||
| static PackedStringArray semantic_labels = String(SUPPORTED_SEMANTIC_LABELS).to_lower().split(","); | |||
There was a problem hiding this comment.
Can you add a comment describing why we're converting to lower case (e.g: to match Godot's automatically converting them to lower-case when saving properties).
There was a problem hiding this comment.
Sure, I added a comment at both the places where we convert the semantic labels to lower-case
dsnopek
force-pushed
the
meta-spatial-entity-mesh
branch
from
3e9e485 to
91ed23f
Compare
m4gr3d
approved these changes
Apr 22, 2024
|
@dsnopek Can you rebase the PR? |
dsnopek
force-pushed
the
meta-spatial-entity-mesh
branch
from
91ed23f to
a882cb0
Compare
|
@m4gr3d Rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a screen shot showing a wire frame (the light white lines) of the global scene mesh, which is what's added to the demo:
This PR also fixes a bug that I noticed in
OpenXRFbSceneManager, with storing the scenes based on semantic label (it was inconsistently converting upper to lower case, causing the properties to not really get set).